Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shout:shriek and shout:wail sounds #35

Merged
merged 5 commits into from
Mar 18, 2022
Merged

Add shout:shriek and shout:wail sounds #35

merged 5 commits into from
Mar 18, 2022

Conversation

KurzedMetal
Copy link
Contributor

@KurzedMetal KurzedMetal commented Mar 16, 2022 •
edited
Loading

PR for #34.

Feel free to mention if you want me to change anything.

This is the best I could do with the tools I have and what I know. No audio changes.

@KurzedMetal KurzedMetal changed the title Add shout:shriek and shout:wail soudns Add shout:shriek and shout:wail sounds Mar 16, 2022
Fris0uman
Fris0uman reviewed Mar 17, 2022
View reviewed changes
Copy link
Owner

@Fris0uman Fris0uman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The echo effect is a bit weird but it adds to strangeness of the scream so I guess it's okay. However they're super loud so you can either lower it in json, setting it to 10 in my test made it pretty okay or edit the file itself to be quieter.

sound/CC-Sounds/shout/shriek/shriek.json Outdated Show resolved Hide resolved
sound/CC-Sounds/shout/wail/wail.json Outdated Show resolved Hide resolved
@KurzedMetal
Copy link
Contributor Author

KurzedMetal commented Mar 17, 2022 •
edited
Loading

I actually noticed it a bit loud and reduced it to 70.

Isn't 10 too low? wouldn't steps be higher than a wail/shriek at that level?

I'll test it locally

@KurzedMetal
Copy link
Contributor Author

KurzedMetal commented Mar 17, 2022 •
edited
Loading

Yeah, 10 is too low IMO, it's even lower than a footstep sound, I wouldn't put it lower than 40-50

That's why I was asking how you were handling volume normalization :P

Fris0uman
Fris0uman reviewed Mar 18, 2022
View reviewed changes
Copy link
Owner

@Fris0uman Fris0uman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick edit to pass the automated test

sound/CC-Sounds/shout/shriek/credits.md Outdated Show resolved Hide resolved
sound/CC-Sounds/shout/wail/credits.md Outdated Show resolved Hide resolved
@Fris0uman
Copy link
Owner

Ok, re-tested with 40 and that works

@Fris0uman Fris0uman merged commit 35866c1 into Fris0uman:main Mar 18, 2022
@Fris0uman Fris0uman mentioned this pull request Mar 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fris0uman Fris0uman Fris0uman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KurzedMetal @Fris0uman