Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows update #5

Merged
merged 3 commits into from
Aug 14, 2021
Merged

Windows update #5

merged 3 commits into from
Aug 14, 2021

Conversation

acepleiades
Copy link
Contributor

Adds open and close window and curtains sounds. As a bonus, also adds a rain on window sound loop as "indoors_rain".

@acepleiades
Copy link
Contributor Author

I can't take screenshots of a sound but I confirmed that it works.

@acepleiades
Copy link
Contributor Author

Now I also added smashing sounds for all doors made out of wood (success and fail) and windows (success only)

@Fris0uman
Copy link
Owner

Pretty nice stuff! A few things to change:

  • Let's try to organise the folders per sound_type id. So one folder for open_door, one for close_door, one for smash etc...
  • door_smash_fail is nice but it could use some more variants, since it's a sound that will be repeated a lot in close proximity it will sound better if it's not always the same exact track each time. That doesn't need to happen in this PR though but that's something to keep in mind
  • the credits.txt could use a smidge more formatting by doing one block of text per author, so just need to insert one empty line between different source. Including the license is nice I'll go back to the one I made yesterday to also include that

@Fris0uman Fris0uman mentioned this pull request Aug 14, 2021
@Fris0uman Fris0uman merged commit b77a7bb into Fris0uman:main Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants