Fixes issue 79, adds missing sound entries to all types of wooden doors #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or. I have now added it to the party.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #79, which reported that not all wooden doors were playing the appropriate sound properly. The reason for this was that, in the soundpack itself, only t_door_o and t_door_c were assigned sounds. In the game files proper, there are about (by my very scientific calculations) 4 billion different door variants. Why do doors t_door_gray, t_door_red, and t_door_green exist? That is a question I cannot answer. I simply jumped into the JSON, added sound file entries for all the open and closed wood door variants I could find, and hoped I pushed the right buttons to fix the issue.
These changes have not been tested, as I’m blind. No version of the game that’s capable of using soundpacks is usable by the blind. Ergo, I cannot test my fix. Also, on a side note, the same issue reported in #79 likely extends across all other types of doors, so they’ll have to be given the same treatment in a future PR.