Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dph #61 onsite dashboard template #558

Merged
merged 12 commits into from
Sep 3, 2024

Conversation

martin-milani-avalith
Copy link
Contributor

@martin-milani-avalith martin-milani-avalith commented Aug 28, 2024

Componentes nuevos
image

Componentes actuales
image

@martin-milani-avalith martin-milani-avalith requested review from GusBaamonde, blancfabian and fgchaio and removed request for GusBaamonde August 29, 2024 16:53
Comment on lines +67 to +68
Dentro de los estilos se encuentra una hoja llamada "_classes.scss" en este archivo se encuentran muchos fix que son para doppler viejo.
En el resto de la aplicación NO deberían utilizar "!important" esto les va a dificultar la reutilización de los componentes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

src/assets/scss/core/_reset.scss Show resolved Hide resolved
src/assets/scss/modules/_forms.scss Show resolved Hide resolved
src/assets/scss/templates/_onsite-dashboard.scss Outdated Show resolved Hide resolved
@fgchaio
Copy link
Contributor

fgchaio commented Sep 3, 2024

Genial!
Si podes cuando publiques a INT comparti un screenshot de como se visualizan los cambios en los componentes actuales y el nuevo dashboard de onsite

@martin-milani-avalith martin-milani-avalith merged commit 2baccea into main Sep 3, 2024
3 checks passed
@martin-milani-avalith martin-milani-avalith deleted the dph-#61-onsite-dashboard-template branch September 3, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants