-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dph #61 onsite dashboard template #558
Merged
martin-milani-avalith
merged 12 commits into
main
from
dph-#61-onsite-dashboard-template
Sep 3, 2024
Merged
Dph #61 onsite dashboard template #558
martin-milani-avalith
merged 12 commits into
main
from
dph-#61-onsite-dashboard-template
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-milani-avalith
force-pushed
the
dph-#61-onsite-dashboard-template
branch
from
August 28, 2024 18:22
404e229
to
656b710
Compare
martin-milani-avalith
force-pushed
the
dph-#61-onsite-dashboard-template
branch
from
August 28, 2024 18:24
656b710
to
fc79a70
Compare
martin-milani-avalith
requested review from
GusBaamonde,
blancfabian and
fgchaio
and removed request for
GusBaamonde
August 29, 2024 16:53
fgchaio
reviewed
Aug 29, 2024
Comment on lines
+67
to
+68
Dentro de los estilos se encuentra una hoja llamada "_classes.scss" en este archivo se encuentran muchos fix que son para doppler viejo. | ||
En el resto de la aplicación NO deberían utilizar "!important" esto les va a dificultar la reutilización de los componentes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
fgchaio
approved these changes
Aug 29, 2024
Genial! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Componentes nuevos
Componentes actuales