-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change tip sorting to ratio between tip and max gas sorting in txpool #1952
Merged
xgreenx
merged 7 commits into
FuelLabs:master
from
AurelienFT:feature/use-ratio-gas-tip
Jun 11, 2024
Merged
Change tip sorting to ratio between tip and max gas sorting in txpool #1952
xgreenx
merged 7 commits into
FuelLabs:master
from
AurelienFT:feature/use-ratio-gas-tip
Jun 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AurelienFT
force-pushed
the
feature/use-ratio-gas-tip
branch
from
June 11, 2024 15:28
c97c72d
to
5514559
Compare
xgreenx
reviewed
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!=) Could you fix the comment related to dependency and we are okay to go=)
xgreenx
approved these changes
Jun 11, 2024
Merged
xgreenx
added a commit
that referenced
this pull request
Jun 14, 2024
## Version v0.29.0 ### Added - [#1889](#1889): Add new `FuelGasPriceProvider` that receives the gas price algorithm from a `GasPriceService` ### Changed - [#1942](#1942): Sequential relayer's commits. - [#1952](#1952): Change tip sorting to ratio between tip and max gas sorting in txpool - [#1960](#1960): Update fuel-vm to v0.53.0. ### Fixed - [#1950](#1950): Fix cursor `BlockHeight` encoding in `SortedTXCursor` ## What's Changed * Fix code coverage compilation and tests by @Dentosal in #1943 * Weekly `cargo update` by @github-actions in #1949 * Fix cursor block height decoding in SortedTXCursor by @AurelienFT in #1950 * Sequential relayer's commits by @xgreenx in #1942 * Add Gas Price Updater Service by @MitchTurner in #1938 * Change tip sorting to ratio between tip and max gas sorting in txpool by @AurelienFT in #1952 * deps(client): update eventsource-client to fix CVE(s) by @Br1ght0ne in #1954 * Update fuel-vm to v0.53.0 by @Dentosal in #1960 ## New Contributors * @AurelienFT made their first contribution in #1950 **Full Changelog**: v0.28.0...v0.29.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1909
Change tip sorting to ratio between tip and max gas sorting in txpool
Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]