-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add browser testing infrastructure #2622
Conversation
This reverts commit 6184bc9.
…/fix/browser-testing
…/fix/browser-testing
@nedsalk any ideas on the validate changeset workflow? I've just reverted the revert commit, and introduced another changeset for my work. |
If the primary purpose of us using the changesets is to generate the changelogs for our releases , I think you can just consolidate this changeset as well as this changeset, into one changeset. Then undo the deletion of this changeset Note Historically changesets have served a different purpose to describe the exact differences between two successive versions of a change such as the git commit message, but based on our release workflow I don't think this applies. |
@danielbate I suggest you rename your PR to be the same as #2378 and remove all the changesets except that PR's because this PR is reintroducing the same work as #2378. I'm suggesting this because #2378 won't show up in the changelog because it was reverted so there won't be any |
…/fix/browser-testing
…/fix/browser-testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💚 🚢 ⛵
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find
Coverage Report:
Changed Files:
|
istanbul
import #2612The majority of this work was introduced by @nedsalk in #2378, this PR will also resolve the flaky coverage import that is described in #2612. Investigation seems to point to flaky ESM bundling being the cause, which I believe to have been resolved here.