Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add browser testing infrastructure #2622

Merged
merged 27 commits into from
Jun 28, 2024
Merged

Conversation

danielbate
Copy link
Contributor

@danielbate danielbate commented Jun 26, 2024

The majority of this work was introduced by @nedsalk in #2378, this PR will also resolve the flaky coverage import that is described in #2612. Investigation seems to point to flaky ESM bundling being the cause, which I believe to have been resolved here.

@danielbate danielbate added the chore Issue is a chore label Jun 26, 2024
@danielbate danielbate added this to the 0.x mainnet milestone Jun 26, 2024
@danielbate danielbate self-assigned this Jun 26, 2024
@github-actions github-actions bot added the bug Issue is a bug label Jun 26, 2024
@danielbate
Copy link
Contributor Author

@nedsalk any ideas on the validate changeset workflow? I've just reverted the revert commit, and introduced another changeset for my work.

@danielbate danielbate marked this pull request as ready for review June 26, 2024 18:32
@maschad
Copy link
Member

maschad commented Jun 26, 2024

@nedsalk any ideas on the validate changeset workflow? I've just reverted the revert commit, and introduced another changeset for my work.

If the primary purpose of us using the changesets is to generate the changelogs for our releases , I think you can just consolidate this changeset as well as this changeset, into one changeset.

Then undo the deletion of this changeset

Note

Historically changesets have served a different purpose to describe the exact differences between two successive versions of a change such as the git commit message, but based on our release workflow I don't think this applies.

@nedsalk
Copy link
Contributor

nedsalk commented Jun 27, 2024

@danielbate I suggest you rename your PR to be the same as #2378 and remove all the changesets except that PR's because this PR is reintroducing the same work as #2378. I'm suggesting this because #2378 won't show up in the changelog because it was reverted so there won't be any chore: add browser testing infrastructure entry in the changelog unless you do it with this PR.

nedsalk
nedsalk previously approved these changes Jun 27, 2024
@danielbate
Copy link
Contributor Author

Good points both 👍🏻 @nedsalk @maschad

@danielbate danielbate changed the title fix: reintroduce browser testing chore: add browser testing infrastructure Jun 27, 2024
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💚 🚢 ⛵

@danielbate danielbate enabled auto-merge (squash) June 27, 2024 11:01
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.54%(-0.75%) 71.37%(-0.43%) 76.91%(-0.65%) 79.62%(-0.75%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/test-utils/launchNode.ts 100%
(+0%)
86.44%
(+0%)
77.77%
(+0%)
94.95%
(+0.04%)
🔴 packages/account/src/test-utils/setup-test-provider-and-wallets.ts 80%
(-20%)
90%
(-10%)
66.66%
(-33.34%)
80%
(-20%)
🔴 ✨ packages/fuels/src/setup-launch-node-server.ts 0%
(+0%)
0%
(+0%)
0%
(+0%)
0%
(+0%)

@danielbate danielbate merged commit 34f1ac7 into master Jun 28, 2024
19 checks passed
@danielbate danielbate deleted the db/fix/browser-testing branch June 28, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser tests are inconsistently failing due to dynamic istanbul import
5 participants