Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: exclude node_modules in template tests #3342

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

danielbate
Copy link
Contributor

@danielbate danielbate commented Oct 17, 2024

Summary

Excludes node_modules from create-fuels template test config.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 2:23pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 2:23pm

Copy link

codspeed-hq bot commented Oct 17, 2024

CodSpeed Performance Report

Merging #3342 will improve performances by ×2.5

Comparing db/chore/exclude-modules-templates (94e145d) with master (9dba357)

Summary

⚡ 1 improvements
✅ 17 untouched benchmarks

Benchmarks breakdown

Benchmark master db/chore/exclude-modules-templates Change
should successfully conduct a custom transfer between wallets (x10 times) 121.5 ms 49.3 ms ×2.5

Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we exclude node_modules from apps/create-fuels-counter-guide/vitest.config.mts as well?

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
75.98%(+0%) 70.07%(+0%) 75.09%(+0%) 76.11%(+0%)
Changed Files:

Coverage values did not change👌.

@Torres-ssf Torres-ssf merged commit 3a56354 into master Oct 21, 2024
24 checks passed
@Torres-ssf Torres-ssf deleted the db/chore/exclude-modules-templates branch October 21, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude node_modules in create-fuels templates
5 participants