chore: add full abi coder tests #3349
Draft
+3,123
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/chore/add-full-abi-coder-tests
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
CodSpeed Performance ReportMerging #3349 will not alter performanceComparing Summary
|
Comment on lines
+107
to
+108
| // propC4: Vec<StructD<u16, u16, StructF<bool>>>, | ||
| // propC5: Vec<StructD<u32, u32, StructF<Vec<StructG>>>>, |
There was a problem hiding this comment.
We should uncomment these and alter tests accordingly.
| expect(value).toEqual(expected); | ||
| }); | ||
| }); | ||
| describe.todo('types_struct_with_multiple_struct_params', () => { |
| .call(); | ||
|
|
||
| const { value } = await waitForResult(); | ||
| // expect(value).toEqual(expected); |
There was a problem hiding this comment.
Missing expect
Comment on lines
+750
to
+753
| describe.todo('types_struct_with_vector'); | ||
| describe.todo('types_struct_with_array_of_enums'); | ||
| describe.todo('types_struct_with_complex_nested_struct'); | ||
| describe.todo('types_struct_with_single_option'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
abi-contract) that taking in fixed inputs, and returns an expected value.@fuel-ts/abi-coder.Interfacefor our new refactored package with absolute certainty of no regression.toEqualBnto make it easier to check returned BN values.Couple issues
// @ts-expect-error: Custom matcher 'toEqualBn') for now.Checklist