Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix impl self node order dependency pass key collision issue. #6407

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Aug 9, 2024

Description

This fixes a key collision issue that happened in the node dependency pass while handling impl self nodes with multiple blocks.

See the following example for a simple example of the problem:

struct A {}

impl A {   //dependency of this impl is overwritten by the next impl
    fn a() {}
    fn b() {}
}

impl A {   //this will overwrite the dependency for the previous impl
    fn ab() {}
}

Fixes the problem by introducing a , while joining the names for the key.

Closes #6319.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

This fixes a key collision issue that happened in the node dependency
pass while handling `impl self/trait` nodes with multiple blocks.

See the following example for a simple example of the problem:

```
struct A {}

impl A {   //dependency of this impl is overwritten by the next impl
    fn a() {}
    fn b() {}
}

impl A {   //this will overwrite the dependency for the previous impl
    fn ab() {}
}
```

Fixes the problem by introducing a `,` while joining the names for the
key.

Closes FuelLabs#6319.
@tritao tritao added P: high Should be looked at if there are no critical issues left compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen labels Aug 9, 2024
@tritao tritao self-assigned this Aug 9, 2024
@tritao tritao marked this pull request as ready for review August 9, 2024 14:06
@tritao tritao requested a review from a team as a code owner August 9, 2024 14:06
@tritao tritao changed the title Fix impl self/trait node order dependency pass key collision issue. Fix impl self node order dependency pass key collision issue. Aug 14, 2024
@tritao tritao enabled auto-merge (squash) August 14, 2024 11:14
@tritao tritao merged commit 798c0e2 into FuelLabs:master Aug 15, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen P: high Should be looked at if there are no critical issues left
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impl block dependency overwriting
3 participants