Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump all crate dependencies after the workspace move #6571

Merged
merged 2 commits into from
Sep 21, 2024

Conversation

alfiedotwtf
Copy link
Contributor

@alfiedotwtf alfiedotwtf commented Sep 19, 2024

Description

This is a continuation of #6179, and follows on from PR #6501. These are broken into separate PRs so that we can discuss each PR HEAD separately so that the PRs that can get merged, do so quickly. Otherwise, the further along they get stale the more work they all need in order to keep up to master without being hard to find which change introduced a possible broken build.

This PR only does a version bump to every crate dependency that does not need any code changes to apply cleanly.

Following this PR will be a new PR, where every commit updates a single crate along with the files that were needed to be changed in order to work again. The crates that will need code changes are:

  • tokio 1.12: -> 1.40
  • rustc-hash: 1.1 -> 2.0
  • miden-core: 0.3 -> 0.10
  • notify: 5.0 -> 6.1
  • notify-debouncer-mini: 0.2 -> 0.4
  • revm: 2.3 -> 14.0
  • syn: 1.0 -> 2.0
  • tikv-jemallocator: 0.5 -> 0.6
  • toml_edit: 0.21 -> 0.22

There should also be a commit to upgrade Rust itself to >= 1.81.0.

... and for another day, there's 3 crates that will take a bit of time to get working, and so will go under a different issue #6536:

  • annotate-snippets
  • lsp-types
  • uint

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@alfiedotwtf alfiedotwtf added ci code quality dependencies dev-experience Anything to do with the developer experience labels Sep 19, 2024
@alfiedotwtf alfiedotwtf self-assigned this Sep 19, 2024
@alfiedotwtf alfiedotwtf requested review from a team as code owners September 19, 2024 20:13
Copy link

codspeed-hq bot commented Sep 19, 2024

CodSpeed Performance Report

Merging #6571 will degrade performances by 16.59%

Comparing alfie/move-crates-and-version-bump-simple (f9e3243) with master (3a6e937)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 19 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master alfie/move-crates-and-version-bump-simple Change
code_lens 6 µs 5.4 µs +11.6%
document_symbol 5.3 ms 4.5 ms +19.47%
format 379.8 ms 455.3 ms -16.59%

@alfiedotwtf alfiedotwtf force-pushed the alfie/move-crates-and-version-bump-simple branch 5 times, most recently from b9674bd to 4f5d136 Compare September 19, 2024 21:47
Cargo.toml Outdated Show resolved Hide resolved
Copy link
Member

@JoshuaBatty JoshuaBatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, happy to approve after fixing the version

@JoshuaBatty JoshuaBatty requested a review from a team September 19, 2024 23:19
@alfiedotwtf alfiedotwtf force-pushed the alfie/move-crates-and-version-bump-simple branch 2 times, most recently from 57902d9 to 0f9644c Compare September 20, 2024 00:58
@alfiedotwtf alfiedotwtf force-pushed the alfie/move-crates-and-version-bump-simple branch from 0f9644c to 522cbfa Compare September 21, 2024 00:37
@JoshuaBatty JoshuaBatty requested review from a team September 21, 2024 03:52
@JoshuaBatty JoshuaBatty merged commit 1d50da1 into master Sep 21, 2024
41 checks passed
@JoshuaBatty JoshuaBatty deleted the alfie/move-crates-and-version-bump-simple branch September 21, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci code quality dependencies dev-experience Anything to do with the developer experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants