-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version bump all crate dependencies after the workspace move #6571
Merged
JoshuaBatty
merged 2 commits into
master
from
alfie/move-crates-and-version-bump-simple
Sep 21, 2024
Merged
Version bump all crate dependencies after the workspace move #6571
JoshuaBatty
merged 2 commits into
master
from
alfie/move-crates-and-version-bump-simple
Sep 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfiedotwtf
added
ci
code quality
dependencies
dev-experience
Anything to do with the developer experience
labels
Sep 19, 2024
CodSpeed Performance ReportMerging #6571 will degrade performances by 16.59%Comparing Summary
Benchmarks breakdown
|
alfiedotwtf
force-pushed
the
alfie/move-crates-and-version-bump-simple
branch
5 times, most recently
from
September 19, 2024 21:47
b9674bd
to
4f5d136
Compare
JoshuaBatty
reviewed
Sep 19, 2024
JoshuaBatty
requested changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, happy to approve after fixing the version
alfiedotwtf
force-pushed
the
alfie/move-crates-and-version-bump-simple
branch
2 times, most recently
from
September 20, 2024 00:58
57902d9
to
0f9644c
Compare
alfiedotwtf
force-pushed
the
alfie/move-crates-and-version-bump-simple
branch
from
September 21, 2024 00:37
0f9644c
to
522cbfa
Compare
JoshuaBatty
approved these changes
Sep 21, 2024
tritao
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a continuation of #6179, and follows on from PR #6501. These are broken into separate PRs so that we can discuss each PR
HEAD
separately so that the PRs that can get merged, do so quickly. Otherwise, the further along they get stale the more work they all need in order to keep up tomaster
without being hard to find which change introduced a possible broken build.This PR only does a version bump to every crate dependency that does not need any code changes to apply cleanly.
Following this PR will be a new PR, where every commit updates a single crate along with the files that were needed to be changed in order to work again. The crates that will need code changes are:
There should also be a commit to upgrade Rust itself to >=
1.81.0
.... and for another day, there's 3 crates that will take a bit of time to get working, and so will go under a different issue #6536:
Checklist
Breaking*
orNew Feature
labels where relevant.