Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix OOB slab panic when creating runnables on a did_save event #6575

Merged
merged 3 commits into from
Sep 21, 2024

Conversation

JoshuaBatty
Copy link
Member

@JoshuaBatty JoshuaBatty commented Sep 21, 2024

Description

I noticed that the language server would crash when compilation was triggered from a did save event as we were trying to create runnables from the Engines that had GC applied to it. We now check to ensure that the correct Engines is accessed to avoid a panic when creating runnables.

After fixing this bug, I noticed that optimised builds was not returning diagnostics. I've opened #6576 to work on this and have temporarily disabled the optimisation so diagnostics continue to work.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@JoshuaBatty JoshuaBatty requested a review from a team as a code owner September 21, 2024 03:41
@JoshuaBatty JoshuaBatty self-assigned this Sep 21, 2024
@JoshuaBatty JoshuaBatty added bug Something isn't working language server LSP server P: critical Should be looked at before anything else labels Sep 21, 2024
@JoshuaBatty JoshuaBatty marked this pull request as draft September 21, 2024 03:41
Copy link

codspeed-hq bot commented Sep 21, 2024

CodSpeed Performance Report

Merging #6575 will degrade performances by 18.06%

Comparing josh/panic_on_save (8cc5062) with master (28c8ae4)

Summary

❌ 1 regressions
✅ 21 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master josh/panic_on_save Change
document_symbol 4.4 ms 5.4 ms -18.06%

@JoshuaBatty JoshuaBatty marked this pull request as ready for review September 21, 2024 04:50
@JoshuaBatty JoshuaBatty requested a review from a team September 21, 2024 04:51
@JoshuaBatty JoshuaBatty requested a review from a team September 21, 2024 05:16
@JoshuaBatty JoshuaBatty merged commit 3a6e937 into master Sep 21, 2024
41 checks passed
@JoshuaBatty JoshuaBatty deleted the josh/panic_on_save branch September 21, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working language server LSP server P: critical Should be looked at before anything else
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants