Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(paging): Fix paging formulas #39

Merged
merged 1 commit into from
Jun 10, 2019
Merged

fix(paging): Fix paging formulas #39

merged 1 commit into from
Jun 10, 2019

Conversation

leontiy
Copy link
Contributor

@leontiy leontiy commented Jun 10, 2019

Issue Link πŸ”—

Formulas for current page number and number of pages were mistakenly inverted during refactoring.

Goals ⚽

It's an urgent bug fix.

Backwards-compatibility:

Fixes backward compatibility. :)

Implementation Details 🚧

β€”

Testing Details πŸ”

I'm testing this on a live project atm.

Copy link
Contributor

@stephanecopin stephanecopin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’―

@leontiy leontiy merged commit 1af4b0b into master Jun 10, 2019
@leontiy leontiy deleted the paging-fixes branch June 10, 2019 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants