Fixes & additional updates #53
Conversation
| /// protocol to represents the button rather than hardcode it to classes, | ||
| /// allowing for any `UIControl` to use this method. | ||
| /// | ||
| var tapped: TapAction<Base>? { |
There was a problem hiding this comment.
I'd welcome a new name here, as pressed is already used, and they semantically are pretty much the same
…es corrupt its internal state
stephanecopin
force-pushed
the
misc/updates
branch
from
98be74c
to
1a6e03f
Compare
| self.applyClosure = { action.apply($0 as! Action.Input).map { $0 }.mapError { $0 } } | ||
| self.events = action.events.map { $0.map { $0 }.mapError { $0 } } | ||
| self.values = action.values.map { $0 } | ||
| self.errors = action.errors.map { $0 } |
There was a problem hiding this comment.
can we write
self.values = action.values
self.errors = action.errors
is .map { $0 } required ?
There was a problem hiding this comment.
@harishsaini it is, to convert to Any or Error through type inference. I could have added as Any in the maps and as Error in the mapError, but I figured it wasn't necessary as it's a common-ish pattern in Swift
stephanecopin
force-pushed
the
misc/updates
branch
from
24ed824
to
1061417
Compare
Codecov Report
@@ Coverage Diff @@
## develop #53 +/- ##
=========================================
Coverage ? 7.34%
=========================================
Files ? 60
Lines ? 1729
Branches ? 0
=========================================
Hits ? 127
Misses ? 1602
Partials ? 0 Continue to review full report at Codecov.
|
stephanecopin
force-pushed
the
misc/updates
branch
4 times, most recently
from
6fc6b8a
to
6963623
Compare
stephanecopin
force-pushed
the
misc/updates
branch
from
6963623
to
29be1b6
Compare
Goals ⚽
This PR:
insetsparameter toaddAndFitSubview(), which should be self-explanatoryremoveArrangedSubviews()'sremoveFromHierachyparameter default totrueOrderedSet, and make it conform toSetAlgebratappedhelper to link anyActionto anyUIControlAnyIdentifiable&AnyActionfor type-erasedIdentifiable&ReactiveActionProtocolrespectivelyOverridingAction, a newActionthat if executed when already executing, will cancel the current one and start anewBackwards-compatibility:
All changes are additive and doesn't break backward compatibility.
Testing Details 🔍
Unit tests were added for
OrderedSet.