fix: phpstan errors

FurkanGM · Mar 26, 2023 · fc96727 · fc96727
1 parent a3273e8
commit fc96727
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 13 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -1,8 +1,5 @@
-includes:
-    - phpstan-baseline.neon
-
 parameters:
-    level: 4
+    level: 5
     paths:
         - src
         - config
@@ -11,4 +8,3 @@ parameters:
     checkOctaneCompatibility: true
     checkModelProperties: true
     checkMissingIterableValueType: false
-
diff --git a/src/Console/Commands/CreatePageTemplateCommand.php b/src/Console/Commands/CreatePageTemplateCommand.php
@@ -14,7 +14,7 @@ class CreatePageTemplateCommand extends GeneratorCommand
 
     protected $type = 'Page Template';
 
-    public function handle()
+    public function handle(): ?bool
     {
         $name = $this->argument('name') ?? $this->ask('What is page template name?');
 
@@ -29,15 +29,15 @@ public function handle()
         if ($this->isReservedName($className)) {
             $this->error('The name "'.$className.'" is reserved by PHP.');
 
-            return;
+            return false;
         }
 
         $path = $this->getPath($className);
 
         if ($this->files->exists($path)) {
             $this->error(basename($className).' already exists!');
 
-            return;
+            return false;
         }
 
         $this->makeDirectory($path);
@@ -53,6 +53,8 @@ public function handle()
         }
 
         $this->info($this->type.' created successfully.');
+
+        return true;
     }
 
     protected function getDefaultNamespace($rootNamespace): string

diff --git a/src/FilamentPageManager.php b/src/FilamentPageManager.php
@@ -41,7 +41,7 @@ public function setResource(string $resource): void
     }
 
     /**
-     * @return class-string<Page>
+     * @return class-string<PageResource>
      */
     public function getResource()
     {

diff --git a/src/Resources/PageResource.php b/src/Resources/PageResource.php
@@ -31,8 +31,8 @@ public static function form(Form $form): Form
                         $additionalOutsideFields = [];
 
                         if ($livewire instanceof (Pages\EditPage::class) || filled($get('template'))) {
-                            $additionalMainFields = $record?->getTemplate()->mainFields() ?? FilamentPageManager::getPageTemplate($get('template'))->mainFields();
-                            $additionalOutsideFields = $record?->getTemplate()->outsideFields() ?? FilamentPageManager::getPageTemplate($get('template'))->outsideFields();
+                            $additionalMainFields = $record->getTemplate()->mainFields() ?? FilamentPageManager::getPageTemplate($get('template'))->mainFields();
+                            $additionalOutsideFields = $record->getTemplate()->outsideFields() ?? FilamentPageManager::getPageTemplate($get('template'))->outsideFields();
                         }
 
                         return array_merge([
@@ -71,10 +71,10 @@ public static function form(Form $form): Form
                                 ->schema([
                                     Forms\Components\Placeholder::make('created_at')
                                         ->label(__('filament-page-manager::fields.creation_date'))
-                                        ->content(fn (?Page $record): string => $record?->created_at->diffForHumans() ?? '-'),
+                                        ->content(fn (?Page $record): string => $record?->created_at->diffForHumans() ?? '-'), /* @phpstan-ignore-line */
                                     Forms\Components\Placeholder::make('updated_at')
                                         ->label(__('filament-page-manager::fields.updated_date'))
-                                        ->content(fn (?Page $record): string => $record?->updated_at->diffForHumans() ?? '-'),
+                                        ->content(fn (?Page $record): string => $record?->updated_at->diffForHumans() ?? '-'), /* @phpstan-ignore-line */
                                 ]),
                         ], $additionalFields);
                     }),