Change frontend of color-stages theme #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rick-nu
previously requested changes
Jan 3, 2019
There was a problem hiding this comment.
Hey @anoukhermsen, thanks a lot for your PR and thinking along with the project!
I think your suggestion is going towards something that looks better than the original, I have some suggestions and additions though.
Since you made the stages/jobs separate blocks now, can we remove de padding between the images too?
Looking forward to the changes :) And please feel free to leave other suggestions or comments when you don't agree with something 👍
…e 31 bold no-standout bg-magenta faint no-underline bg-cyan standout no-blink bg-white underline 33 41 01 blink no-reverse bg-default 27 no-conceal reverse conceal 30 31 08 39 02 32 24 45 35 05 34 30 39 47 black 23 red green 43 yellow 36 blue magenta 37 cyan 03 white 44 35 default 40 28 07 46 04 33 37 40 22 34 42 00 30 30 25 49 bg-black 36 32 bg-red bg-green bg-yellow-gray-dark
anoukhermsen
changed the title
|
Thanks @anoukhermsen! I think the color stages theme is looking a lot better now, at least a lot less html-table like as you mentioned 😇 Everything is looking fine now, I'm merging it and tagging a new release! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make the job status prettier with more difference between the column and the pipeline stages
Why
To give the pipeline more dimension and make the style not too square