adds desktop notification filtering #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rick-nu
reviewed
Jan 18, 2019
rick-nu
reviewed
Jan 18, 2019
rick-nu
reviewed
Jan 18, 2019
rick-nu
reviewed
Jan 18, 2019
rick-nu
reviewed
Jan 18, 2019
rick-nu
reviewed
Jan 18, 2019
rick-nu
reviewed
Jan 18, 2019
|
Thanks for the critical review. commit 12f9462 should improve this PR. |
rick-nu
approved these changes
Jan 18, 2019
|
Looks great! Thanks for the improvements @steefmin! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds filtering to the desktop notification functionality added in #64.
Why
Currently, when the desktop notifications are enabled, you will receive a notification of each update of the status of your pipeline. However most users are only interested in two of the cases:
and even more important
This PR allows you to select which statuses you want to be notified of. By default the 'error' and 'success' states will be notified, the others are disabled.