adds deployer adapter #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rick-nu
requested changes
Jan 18, 2019
There was a problem hiding this comment.
@steefmin awesome! Super cool that it's already accepted in deployer too!
some comments:
-
The
mkdocs.ymlentry is missing for the new page in your documentation. Without that the page won't show. -
Is it possible to add cypress tests for the deployer webhook? That way we can always verify that everything works as expected.
Thanks a lot!
rick-nu
reviewed
Jan 18, 2019
rick-nu
reviewed
Jan 18, 2019
|
@RickvdStaaij fixed the documentation issues. The tests will take some time. Will notify you when everything runs smoothly. |
rick-nu
reviewed
Jan 18, 2019
|
@RickvdStaaij could you verify I didn't forget anything. Then it should be ''Golden'' |
|
@steefmin impressive!!! Super nice! Thank you! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds an adapter for Deployer (deployer.org) calls.
Why
For deployments that are not performed from Gitlab, it is nice to also have the status displayed on CIMonitor. This adds the required adapter for receiving the calls from the deployer recipe from deployerphp/recipes#204