Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hostname in dashboard title #110

Merged
merged 4 commits into from
Jan 25, 2019
Merged

Conversation

steefmin
Copy link

What

A simple JS line that adds the hostname in the title.

Why

If you, just as me, have multiple CIMonitors open in one browser, it is almost impossible to distinguish between them. This PR gives you more information.

Copy link
Member

@rick-nu rick-nu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @steefmin, another nice addition! I have some suggestions though.

In the future I would like the page title to be configurable in the CIMonitor config, but this is a very sane default! I like it!

front-end/index.html Outdated Show resolved Hide resolved
@rick-nu
Copy link
Member

rick-nu commented Jan 25, 2019

Codewise looking good! Checking functionally

Copy link
Member

@rick-nu rick-nu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm! 👍

@rick-nu rick-nu merged commit 1aa6e92 into FuturePortal:master Jan 25, 2019
@T-888 T-888 mentioned this pull request Jan 25, 2019
@steefmin steefmin deleted the hostname-title branch June 14, 2019 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants