add icons to the statusses #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rick-nu
requested changes
Jan 25, 2019
There was a problem hiding this comment.
Thank you for your PR @anoukhermsen. Cool to see the icons added! Nice!
Some small findings in the PR, and another suggestion:
Can we make set padding: 5px 10px on the .status__detail-stage, .status__detail-job? That gives the jobs a bit more display space :D
rick-nu
reviewed
Jan 25, 2019
rick-nu
approved these changes
Jan 25, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add icons to the status__detail
Why
To make the theme even prettier and make differences between warning and running