Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add automated old status cleaning interval every hour #113

Merged
merged 2 commits into from
Jan 25, 2019
Merged

Add automated old status cleaning interval every hour #113

merged 2 commits into from
Jan 25, 2019

Conversation

rick-nu
Copy link
Member

@rick-nu rick-nu commented Jan 25, 2019

What

Add automated old status cleaning interval every hour.

Why

  • Statuses were only removed when a new event was pushed. If nothing was pushed for 1 weeks, old statuses would still show on the dashboard. These are now automatically removed after their expire time (which is 1 week currently)

steefmin
steefmin reviewed Jan 25, 2019
View reviewed changes
Copy link

@steefmin steefmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit hard to test, but codewise looks all shiny.

I left one naming comment up there.

@rick-nu
Copy link
Member Author

rick-nu commented Jan 25, 2019

Valid point, discussed and improved 👍

steefmin
steefmin approved these changes Jan 25, 2019
View reviewed changes
Copy link

@steefmin steefmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This clarifies the statusremoval throughout the system 👍 let's start with the hourly removal, we can always tweak the interval

@rick-nu
Copy link
Member Author

rick-nu commented Jan 25, 2019

Thank you for reviewing @steefmin!

@rick-nu rick-nu merged commit 2488b21 into FuturePortal:master Jan 25, 2019
@T-888 T-888 mentioned this pull request Jan 25, 2019
Merged
@rick-nu rick-nu deleted the remove-old-statuses branch April 9, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steefmin steefmin steefmin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rick-nu @steefmin