[#125] Add configurable storage for statuses and config #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rick-nu
requested changes
Mar 25, 2019
There was a problem hiding this comment.
Some small codewise improvements, but overal looking great so far, impressive @eXistenZNL! 😄
eXistenZNL
commented
Mar 25, 2019
eXistenZNL
commented
Mar 25, 2019
…ing from Firebase, rename an environment variable
rick-nu
reviewed
Apr 1, 2019
rick-nu
reviewed
Apr 1, 2019
…the config structure when loading from Firebase
rick-nu
reviewed
Apr 2, 2019
rick-nu
reviewed
Apr 2, 2019
rick-nu
reviewed
May 1, 2019
rick-nu
reviewed
May 1, 2019
rick-nu
reviewed
May 1, 2019
rick-nu
reviewed
May 1, 2019
rick-nu
reviewed
May 1, 2019
rick-nu
reviewed
May 1, 2019
rick-nu
reviewed
May 1, 2019
rick-nu
reviewed
May 1, 2019
rick-nu
reviewed
May 1, 2019
rick-nu
reviewed
May 1, 2019
rick-nu
reviewed
May 1, 2019
rick-nu
reviewed
May 1, 2019
rick-nu
reviewed
May 1, 2019
rick-nu
reviewed
May 1, 2019
rick-nu
requested changes
May 1, 2019
|
|
…ockerignore for both containers.
eXistenZNL
changed the title
rick-nu
reviewed
May 10, 2019
rick-nu
reviewed
May 10, 2019
|
YESS YESS YOOOOOOO Finally, super excited to directly test this on production 🤞 |
rick-nu
approved these changes
May 10, 2019
|
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Ticket
Closes #125
Why
When running the Docker container, all state is lost when updating. By having the config and statuses stored externally, we can keep state when updating.
Todo