Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide mouse pointer after X miliseconds #127

Merged
merged 6 commits into from
May 8, 2019
Merged

Hide mouse pointer after X miliseconds #127

merged 6 commits into from
May 8, 2019

Conversation

Doqnach
Copy link

@Doqnach Doqnach commented May 6, 2019

What

This PR adds a configuration option to hide the mouse cursor after X miliseconds of not moving, and shows it again when moving.

Why

Even though a program like unclutter exists, this method works without dependencies.
I chose to use the CSS way, since the Cursor Lock API has the huge downside of needing user interaction for it to work.

Copy link
Member

@rick-nu rick-nu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Doqnach awesome first PR! Looks great!

I have some feedback, if you're willing to resolve it that would be great, if not I can do it for you. After the comments are resolved I'll be sure to merge this and tag a new version! Cool!

front-end/dashboard.js Outdated Show resolved Hide resolved
front-end/dashboard.js Outdated Show resolved Hide resolved
front-end/dashboard.js Outdated Show resolved Hide resolved
@rick-nu
Copy link
Member

rick-nu commented May 8, 2019

Thanks @Doqnach! Looking good! Since you're running the local version, ask Dennis to pull the latest master 😉 Will release it together with the firebase PR (if @eXistenZNL ever finished that).

Merging!

@rick-nu rick-nu merged commit 2d192dc into FuturePortal:master May 8, 2019
@T-888 T-888 mentioned this pull request May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants