Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saved-statuses.json path #145

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Fix saved-statuses.json path #145

merged 1 commit into from
Aug 8, 2019

Conversation

robindv
Copy link

@robindv robindv commented Aug 7, 2019

What

Currently the saved-statuses.json file is saved in back-end/config instead of the config-directory because of relative path madness.

Why

According to #144 this should be the expected behavior.

Copy link
Member

@rick-nu rick-nu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, makes sense that this broke this way with the new persister abstraction. Thanks a lot for fixing the issue! 👍

@rick-nu rick-nu merged commit 11363ac into FuturePortal:master Aug 8, 2019
@T-888 T-888 mentioned this pull request Aug 8, 2019
@rick-nu
Copy link
Member

rick-nu commented Aug 8, 2019

Released in https://github.com/CIMonitor/CIMonitor/releases/tag/3.5.1 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants