Prioritize running job over success or failed status #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This change prioritizes the global state of running jobs over the end states (failure / success). If a pipeline is running, the favicon and bottom traffic light will be yellow, once the pipeline is completed the favicon + traffic light will be green or red again.
Why
I recently have been using CIMonitor in a (pinned) tab quite a lot as a simple indicator if the pipeline was still running or already done. Whenever I would have failed pipelines on my dashboard (this can happen quite some times when running e.g. Renovate or Dependabot), the indicator never switches to yellow so I still have to check the CIMonitor page manually to know if the pipeline I just triggered is already done.
With this change, the favicon will update itself to yellow whenever a pipeline starts, then back to red or green again when the pipeline is completed.
In other words, this makes the favicon / traffic light more usable in different scenario's!