Add version checker and refactor get contributors #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eXistenZNL
reviewed
Nov 29, 2018
eXistenZNL
reviewed
Nov 29, 2018
|
Fixed a lot of stuff, however I'm not sure yet if I actually want to ship this version checking stuff. need to sleep on it. |
|
I've slept on it, and I think this does add value. The server side is set up neatly, yet the client side could be cleaner. @eXistenZNL what do you think about the current state? |
eXistenZNL
previously requested changes
Nov 30, 2018
rick-nu
dismissed
eXistenZNL’s stale review
Commented & resolved discussions
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add version checker and refactor get contributors
To do
index.htmlSave the version in a separate file innot doing this, just keep thedist/, so the docker container doesn't have to keep extra shitpackage.jsonfor now.