Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch zwave-js code when it hasn't already been fetched #200

Merged
merged 9 commits into from
Jul 28, 2021

Conversation

raman325
Copy link
Collaborator

@raman325 raman325 commented Jul 17, 2021

Proposed change

We need to merge this first before the other PR but we also need to make some changes in the upstream library (home-assistant-libs/zwave-js-server-python#257) and release that before we can merge this.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

@raman325 raman325 added the enhancement New feature or request label Jul 17, 2021
@raman325 raman325 marked this pull request as ready for review July 28, 2021 22:19
@raman325 raman325 added the bugfix Fixes a bug label Jul 28, 2021
Copy link
Collaborator

@firstof9 firstof9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested changes on live system, confirming it works.

@raman325 raman325 merged commit 58ffa10 into FutureTense:main Jul 28, 2021
@raman325 raman325 deleted the fetch_code branch July 28, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISSUE: Setup failed: unknown error
2 participants