-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 사용자 과제 히스토리 조회 응답 필드에 제출 실패 사유 추가 #667
Conversation
Walkthrough사용자 과제 히스토리 조회 API에 Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant API
participant AssignmentHistory
User->>API: 과제 히스토리 요청
API->>AssignmentHistory: 과제 데이터 요청
AssignmentHistory-->>API: 과제 데이터 및 제출 실패 사유 반환
API-->>User: 과제 히스토리 및 실패 사유 응답
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Job Summary for GradleCheck Style and Test to Develop :: build-test
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/main/java/com/gdschongik/gdsc/domain/study/dto/response/AssignmentHistoryResponse.java (3 hunks)
Additional comments not posted (3)
src/main/java/com/gdschongik/gdsc/domain/study/dto/response/AssignmentHistoryResponse.java (3)
5-5
: 필요한 import 추가 확인.
SubmissionFailureType
의 import가 적절하게 추가되었습니다. 사용되는 필드에 맞게 잘 반영되었습니다.
16-16
: 새로운 필드 추가 확인.
submissionFailureType
필드가 올바르게 추가되었습니다. API 문서화를 위한@Schema
주석도 적절하게 사용되었습니다.
26-26
:from
메서드 업데이트 확인.
from
메서드가assignmentHistory.getSubmissionFailureType()
을 포함하도록 올바르게 업데이트되었습니다. 새로운 필드가 생성자에 잘 전달됩니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🌱 관련 이슈
📌 작업 내용 및 특이사항
📝 참고사항
📚 기타
Summary by CodeRabbit
AssignmentHistoryResponse
에 추가하여 API 응답의 데이터 표현력을 향상시켰습니다.