feat: 내 할일 목록 조회 API 추가 #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/670-get-todo-list
Walkthrough이번 변경 사항은 Changes
Sequence Diagram(s)sequenceDiagram
participant Controller
participant Service
participant Repository
participant DTO
Controller->>Service: getStudyTodoList(studyId)
Service->>Repository: fetchStudyDetails(studyId)
Repository-->>Service: studyDetails
Service->>Repository: fetchAttendanceHistory(memberId, studyId)
Repository-->>Service: attendanceHistory
Service->>Repository: fetchAssignmentHistories(memberId, studyId)
Repository-->>Service: assignmentHistories
Service-->>DTO: createStudyTodoResponse(studyDetails, attendanceHistory, assignmentHistories)
DTO-->>Controller: List<StudyTodoResponse>
Controller-->>Client: ResponseEntity<List<StudyTodoResponse>>
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Job Summary for GradleCheck Style and Test to Develop :: build-test
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- src/main/java/com/gdschongik/gdsc/domain/study/api/StudentStudyDetailController.java (2 hunks)
- src/main/java/com/gdschongik/gdsc/domain/study/application/StudentStudyDetailService.java (2 hunks)
- src/main/java/com/gdschongik/gdsc/domain/study/domain/StudyDetail.java (2 hunks)
- src/main/java/com/gdschongik/gdsc/domain/study/domain/vo/Assignment.java (1 hunks)
- src/main/java/com/gdschongik/gdsc/domain/study/domain/vo/Session.java (1 hunks)
- src/main/java/com/gdschongik/gdsc/domain/study/dto/response/StudyTodoResponse.java (1 hunks)
Additional context used
Learnings (1)
src/main/java/com/gdschongik/gdsc/domain/study/application/StudentStudyDetailService.java (1)
Learnt from: Sangwook02 PR: GDSC-Hongik/gdsc-server#431 File: src/main/java/com/gdschongik/gdsc/domain/study/application/StudyService.java:50-57 Timestamp: 2024-07-07T15:32:34.451Z Learning: Consider using Stream API for creating lists in a more concise and potentially performant manner compared to traditional for-loops.
Additional comments not posted (5)
src/main/java/com/gdschongik/gdsc/domain/study/domain/vo/Session.java (1)
60-62: 새로운 메서드isOpened()추가 확인세션의 상태를 확인하는 메서드로, 코드의 가독성과 유지보수성을 높입니다. 변경 사항이 잘 반영되었습니다.
src/main/java/com/gdschongik/gdsc/domain/study/api/StudentStudyDetailController.java (1)
33-38: 새로운 엔드포인트getStudyTodoList추가 확인API 문서화가 잘 되어 있으며, 서비스 레이어와의 통합도 적절하게 이루어졌습니다. 변경 사항이 잘 반영되었습니다.
src/main/java/com/gdschongik/gdsc/domain/study/dto/response/StudyTodoResponse.java (1)
1-53: 새로운 파일StudyTodoResponse추가 확인레코드와 관련 메서드가 잘 정의되어 있으며, 할일 타입을 구분하기 위한 enum과 정적 팩토리 메서드의 사용이 적절합니다. 변경 사항이 잘 반영되었습니다.
src/main/java/com/gdschongik/gdsc/domain/study/domain/vo/Assignment.java (1)
88-90: 새로운 메서드isOpened()추가 확인
isOpened()메서드는 과제의 상태가OPEN인지 확인하는 기능을 제공합니다. 이 추가는 클래스의 표현력을 향상시킵니다.src/main/java/com/gdschongik/gdsc/domain/study/domain/StudyDetail.java (1)
100-118:getAttendanceDay메서드 리팩토링 확인이 메서드는 여러 단계로 나누어져 가독성과 유지보수성을 향상시켰습니다. 주간 전환을 고려한 논리도 포함되어 있습니다.
src/main/java/com/gdschongik/gdsc/domain/study/application/StudentStudyDetailService.java
Outdated
Show resolved
Hide resolved
Sangwook02
requested changes
Aug 22, 2024
src/main/java/com/gdschongik/gdsc/domain/study/domain/vo/Session.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gdschongik/gdsc/domain/study/domain/vo/Assignment.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gdschongik/gdsc/domain/study/dto/response/StudyTodoResponse.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gdschongik/gdsc/domain/study/dto/response/StudyTodoResponse.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gdschongik/gdsc/domain/study/application/StudentStudyDetailService.java
Outdated
Show resolved
Hide resolved
…into feature/670-get-todo-list
Job Summary for GradleCheck Style and Test to Develop :: build-test
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- src/main/java/com/gdschongik/gdsc/domain/study/application/StudentStudyDetailService.java (2 hunks)
- src/main/java/com/gdschongik/gdsc/domain/study/domain/StudyDetail.java (2 hunks)
- src/main/java/com/gdschongik/gdsc/domain/study/domain/vo/Session.java (1 hunks)
- src/main/java/com/gdschongik/gdsc/domain/study/dto/response/StudyTodoResponse.java (1 hunks)
Files skipped from review as they are similar to previous changes (4)
- src/main/java/com/gdschongik/gdsc/domain/study/application/StudentStudyDetailService.java
- src/main/java/com/gdschongik/gdsc/domain/study/domain/StudyDetail.java
- src/main/java/com/gdschongik/gdsc/domain/study/domain/vo/Session.java
- src/main/java/com/gdschongik/gdsc/domain/study/dto/response/StudyTodoResponse.java
Sangwook02
reviewed
Aug 23, 2024
…into feature/670-get-todo-list
Job Summary for GradleCheck Style and Test to Develop :: build-test
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이사항
📝 참고사항
📚 기타
Summary by CodeRabbit
New Features
StudyTodoResponse클래스 도입.isOpened()메서드 추가.Bug Fixes
getAttendanceDay메서드의 가독성과 유지 관리성을 개선하여 더 명확한 계산 로직 제공.