Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 마이페이지 계정정보 조회 API 추가 #672
feat: 마이페이지 계정정보 조회 API 추가 #672
Changes from 2 commits
ce4effd
83bbc1b
b4a4ad3
e381f78
d56e606
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
라이브러리 잠깐 살펴봤는데요, GithubConnector를 implements 하여 DI하지 않고, 그냥 GithubClient 에서 바로 DEFAULT 구현체로 초기화해버리면 될 것 같은데 어떻게 생각하시나요?
private final GitHubConnector githubConnector = GitHubConnector.DEFAULT;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그렇네요.
특별한 구현 없으니 이게 더 간단하고 깔끔할 것 같네요.
반영할게요!