-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 스터디 개강일 전에도 내 수강중인 스터디 조회 API에서 선별할 수 있도록 수정 #694
refactor: 스터디 개강일 전에도 내 수강중인 스터디 조회 API에서 선별할 수 있도록 수정 #694
Conversation
Walkthrough변경된 내용은 Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Job Summary for GradleCheck Style and Test to Develop :: build-test
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/main/java/com/gdschongik/gdsc/domain/study/application/StudentStudyService.java (2 hunks)
Additional comments not posted (2)
src/main/java/com/gdschongik/gdsc/domain/study/application/StudentStudyService.java (2)
20-20
:LocalDateTime
import 확인
LocalDateTime
을 사용하여 날짜와 시간을 비교하는 것은 적절합니다.변경 사항이 승인되었습니다.
110-111
: 필터링 조건 확인현재 날짜와 시간이 스터디의 신청 시작일과 종료일 사이에 있는지 확인하는 필터링 조건이 올바르게 적용되었습니다.
변경 사항이 승인되었습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🌱 관련 이슈
📌 작업 내용 및 특이사항
수강중인 스터디 조회 API
가 수강중인 스터디를 null로 반환하고 있습니다.이를 방지하기 위해 필터링 조건을
신청 시작일~종강일
로 변경했습니다.📝 참고사항
📚 기타
Summary by CodeRabbit
새로운 기능
버그 수정