refactor: BaseSemesterEntity 수정자 제거

[Sangwook02]

🌱 관련 이슈

• close ♻️ BaseSemesterEntity 수정자 제거 #714

📌 작업 내용 및 특이사항

📝 참고사항

📚 기타

Summary by CodeRabbit

• 버그 수정
  • BaseSemesterEntity 클래스에서 updateAcademicYear 및 updateSemesterType 메서드가 제거되어, 해당 속성을 직접 수정할 수 없게 되었습니다. 이로 인해 클래스의 불변성이 강화되었습니다.

[coderabbitai]

Walkthrough

BaseSemesterEntity 클래스에서 두 개의 보호 메서드인 updateAcademicYear와 updateSemesterType가 제거되었습니다. 이로 인해 해당 클래스의 academicYear와 semesterType 속성을 직접 수정할 수 있는 방법이 사라졌습니다. 이러한 변경은 클래스의 속성 캡슐화를 강화하고, 인스턴스의 불변성을 높이는 방향으로 진행되었습니다.

Changes

파일 경로	변경 요약
src/main/java/com/gdschongik/gdsc/domain/common/model/BaseSemesterEntity.java	updateAcademicYear 및 updateSemesterType 메서드 제거

Assessment against linked issues

Objective	Addressed	Explanation
수정자 제거 (#714)	✅

🐰 새로운 변화가 와서
학기와 연도도 바뀌어 가네,
수정자 없이도 우린 잘 지내,
더 단단해진 클래스의 모습,
불변의 힘을 느껴보세! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Job Summary for Gradle

Check Style and Test to Develop :: build-test

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
gdsc	check	8.5	✅

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0eb992e and 6a84833.

Files selected for processing (1)

• src/main/java/com/gdschongik/gdsc/domain/common/model/BaseSemesterEntity.java (1 hunks)

Additional comments not posted (4)

src/main/java/com/gdschongik/gdsc/domain/common/model/BaseSemesterEntity.java (4)

Line range hint 1-1: 패키지 선언 확인

패키지 선언이 올바르게 되어 있습니다.

패키지 선언이 적절합니다.

---

Line range hint 3-9: 필요한 import 문 확인

필요한 import 문이 모두 포함되어 있습니다.

import 문이 적절합니다.

---

Line range hint 11-20: 클래스 선언 및 어노테이션 확인

클래스 선언과 어노테이션이 적절하게 사용되었습니다.

클래스 선언과 어노테이션이 적절합니다.

---

Line range hint 22-26: 필드 선언 확인

academicYear와 semesterType 필드가 적절하게 선언되었습니다.

필드 선언이 적절합니다.

[seulgi99]

LGTM

[uwoobeat]

lgtm