Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issues with index.html, styles.css and scripts.js #41

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Bhagy3sh
Copy link

To resolve the issues identified in the index.html file, we added an appropriate action attribute to the

element, ensuring it submits payment information correctly. We also grouped the input fields for the card number under a single label to enhance accessibility for screen readers. Additionally, we updated the placeholders for the card number inputs to clarify that users should enter four groups of four digits instead of a single group. For the script.js file, we corrected the card expiration month index calculation to accurately reflect zero-based indexing, preventing incorrect expiration dates. We removed the duplicated event handler for the #card-holder input field, streamlining the code and reducing unnecessary processing. The previously commented-out function getCreditCardType() was implemented to better classify card types, and we ensured that the #card-ccv element is present in the HTML to match the script's functionality. In the styles.css file, we completed the &::after pseudo-element definition for the .btn class to prevent layout issues. We also added visible focus outlines to the form fieldsets, improving accessibility for keyboard users. Lastly, we ensured the SCSS syntax was correctly compiled into CSS to guarantee that styles apply as intended across all elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant