-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a multidimensional wrapper around c-array #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead it is deduced from the caller of the member functions.
wrtobin
reviewed
Nov 30, 2023
wrtobin
reviewed
Nov 30, 2023
src/discretizations/finiteElementMethod/parentElements/ParentElement.hpp
Show resolved
Hide resolved
wrtobin
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only two small things we can remove, other than getting the cuda builds passing this looks solid.
…mation classes to avoid warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for better use of compile time known dimension c-arrays, and provides indexing accessors that take a parameter pack.
note...after a while I wondered why I didn't just replicate the interface of
std::mdspan
or ratherstd::mdarray
coming inc++23
, but you can't really anyways since they overload theoperator[]
to follow something like:which you can't do until
c++23
.We can certainly replicate the dependence on
std::extents
, which is alsoc++23
but functionally simple if we don't try to do a bunch withdynamic_extents
.