use images from docker_base_images repository #34
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 34 34
Lines 1088 1088
=========================================
Hits 1088 1088 ☔ View full report in Codecov by Sentry. |
rrsettgast
force-pushed
the
feature/use_geos_base_images
branch
from
dfd8efa
to
0386e98
Compare
| "build": { | ||
| "dockerfile": "Dockerfile", | ||
| "args": { | ||
| "docker_image_tag_hash": "b5b06ad736cc8f2df227dabf8ff1da1a2f538939" |
There was a problem hiding this comment.
An idea could be to also have a 22.04-b5b....939?
There was a problem hiding this comment.
you mean to avoid the long hash?
There was a problem hiding this comment.
I do not know how you generate this hash. It looks to me that you use one unique image for all your builds?
In geos, we "play" with the repository name (like ubuntu-22-gcc10...) and the hash is unique and matches versions of the TPLs. It depends on what you want to do for Shiva. Still, it's no big deal to make this evolve in the future.
There was a problem hiding this comment.
the hash is from the docker_base_images repository. I would like to standardize the images we use for testing across the project repos.
| "customizations": { | ||
| "vscode": { | ||
| "extensions": [ | ||
| "eamodio.gitlens", | ||
| "fredericbonnet.cmake-test-adapter", | ||
| "GitHub.vscode-github-actions", | ||
| "GitHub.vscode-pull-request-github", | ||
| "ms-vscode.cpptools-extension-pack", | ||
| "redhat.vscode-xml" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
All this file is mainly if you're using codespaces, which is still not your case?
If you want, you can simplify it a lot, or simply embed the b5...39 hash into your continuousIntegration.yml with some echo "DOCKER_IMAGE_TAG_HASH=b5...39" >> "$GITHUB_OUTPUT".
There was a problem hiding this comment.
I think we would want to enable codespaces even though I don't personally use it now....I would like to try it soon.
There was a problem hiding this comment.
OK, it believe it's a great feature at low (setup and maintenance) cost!
This PR deletes the docker files from this repo, and relies on images from https://github.com/GEOS-DEV/docker_base_images