Multiple improvements #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tic contexts e.g. '(( a == b ))'
…the case that you should consider 'case'
…the case that you should consider 'case'.
… UPPERCASE variables - a suboptimal practice.
…e correct convention. '2' usually means a misuse of a shell builtin, which thse conditions are not.
|
Consistent cuddling ( ͡ ° ͜ °) |
|
@rawiriblundell I love the improvements , the changes , everything . Waiting for my collaborator to also approve and we will surely merge it to main as soon as possible (っ´ω`c)♡ tnx for the help |
lefterisgar
requested changes
Sep 11, 2022
|
However, I agree with @GEROGIANNIS. The code is perfect otherwise and I'm really glad that someone has stepped in and decided to contribute to Limoji! |
lefterisgar
approved these changes
Sep 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
This is a suggested set of fixes and improvements. I've tried to keep them split up into separate commits, so that you can review and cherry pick.
Cheers!