Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use require to resolve dependencies #45

Closed
boldtrn opened this issue Jun 22, 2019 · 0 comments
Closed

Use require to resolve dependencies #45

boldtrn opened this issue Jun 22, 2019 · 0 comments

Comments

@boldtrn
Copy link
Contributor

boldtrn commented Jun 22, 2019

Currently, the dependencies need to be resolved by the developers including the plugin and are not resolved by NPM automatically. It would be nice to include them for example with:

require('d3-select')
TheGreatRefrigerator added a commit that referenced this issue Oct 21, 2019
@TheGreatRefrigerator
Switch from bower to node dependencies
9cbfca6 
refers to #45
mrubli added a commit to mrubli/Leaflet.Heightgraph that referenced this issue Jun 17, 2020
@mrubli
Add browserify step and d3 dependency
751bb45 
This addresses GIScience#45.
mrubli added a commit to mrubli/Leaflet.Heightgraph that referenced this issue Jun 19, 2020
@mrubli
Add browserify step and d3 dependency
20603e4 
This addresses GIScience#45
mrubli added a commit to mrubli/Leaflet.Heightgraph that referenced this issue Jun 19, 2020
@mrubli
Add browserify step and d3 dependency
e9c0226 
This addresses GIScience#45

For now this change creates inline source maps but we'll fix this
shortly to match the original behavior.
@mrubli mrubli mentioned this issue Jun 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@boldtrn