Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the style #63

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Updated the style #63

merged 1 commit into from
Jul 17, 2019

Conversation

boldtrn
Copy link
Contributor

@boldtrn boldtrn commented Jul 17, 2019

Fixes #60

I updated the style a bit. I personally like it better that way :). But these changes are always quite opinionated.

That's how the style looks right now:
Screenshot from 2019-07-17 17-24-47

What I changed:

  • I added a background transparency
  • I removed the stroke for the top border, as this can look a bit ugly for long routes (~ >300km), depending on the width of the graph
  • The axis and labels are now black to make it easier to read
  • I fixed the font-size for mouse hover box. Before the font-size would fallback to the default font size of the document and there was no easy way to fix it.

WDYT @TimMcCauley should we merge this? Especially the black axis and background transparency are a bit opinionated. I could remove these changes from the PR.

@boldtrn boldtrn requested a review from TimMcCauley July 17, 2019 15:32
Copy link
Contributor

@TimMcCauley TimMcCauley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boldtrn I agree with these changes, the opacity makes it easier to read and removing the stroke is absolutely fine! Thank you.

@TimMcCauley TimMcCauley merged commit e0546f8 into GIScience:master Jul 17, 2019
@boldtrn boldtrn deleted the update_style branch July 18, 2019 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add light transparency to background
2 participants