Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map frame resize #215

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Map frame resize #215

wants to merge 8 commits into from

Conversation

joker234
Copy link
Member

@joker234 joker234 commented Feb 10, 2023

This PR is meant as a proposal how we could reduce the map frame size. This size is later also used to determine (and heavily influence) the resource capacity needed for the processing tasks (especially the openCV tasks).

Open ToDos:

  • Test if map_frame in database still has the correct ratio and looks alright.
  • Find a reasonable max_length (maximum number of pixel on either height or width for saved map frame)
  • Write tests

Copy link
Contributor

@mhhd2020 mhhd2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added tests and found 2000 to be a suitable value (1000 led to quite pixelated GeoTIFFs). Please review these changes and additions - if you are fine with them, it should be ready to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants