Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable opt-out of the usage of uploaded sketch maps for the improvement of the tool #457

Merged
merged 9 commits into from
Jun 5, 2024
Merged

Enable opt-out of the usage of uploaded sketch maps for the improvement of the tool #457

merged 9 commits into from
Jun 5, 2024

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented Jun 3, 2024 •
edited
Loading

  • Implement in the frontend
  • Implement in the backend (routes and DB client)
  • Update database schema (backend and production DB)
  • Add missing test
  • Release and Deploy

After deployment run:

UPDATE blob
SET consent = true
WHERE ts is not NULL;

Update docs on confluence.

Closes #455

@matthiasschaub matthiasschaub marked this pull request as ready for review June 5, 2024 09:11
@matthiasschaub matthiasschaub merged commit 33429b1 into main Jun 5, 2024
1 check passed
@matthiasschaub matthiasschaub deleted the opt-out branch June 5, 2024 14:01
joker234
joker234 reviewed Jun 5, 2024
View reviewed changes
sketch_map_tool/templates/digitize.html
@@ -48,6 +48,7 @@
</div>
<div>
<p>
<input type="checkbox" id="consent" name="consent" value="True" checked>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the id/name shouldn't just be consent. Ideally it would indicate what you consent to.

sketch_map_tool/templates/digitize.html
Comment on lines 52 to 53
{{ _('By uploading the file(s), you agree that the content of the files and the time of upload will
be saved and used for the further development of the service.') }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text doesn't fit for a checkbox. It states that “if you upload the files, you consent”, not “by checking the box …”. Before merging this needs reviewing.

joker234
joker234 reviewed Jun 5, 2024
View reviewed changes
Copy link
Member

@joker234 joker234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this change should not be released without actually implementing a difference for entries that have wanted us to use their data for improvements or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joker234 joker234 joker234 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make opt-out of using uploaded sketch map for improvement of the tool possible
3 participants
@matthiasschaub @joker234 @Gigaszi