-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tasks/routes): process uploaded files in parallel as celery groups #504
Open
matthiasschaub
wants to merge
18
commits into
main
Choose a base branch
from
split-georeferencing-into-multiple-tasks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasschaub
force-pushed
the
split-georeferencing-into-multiple-tasks
branch
2 times, most recently
from
September 5, 2024 14:32
cd6ab84
to
2d2498b
Compare
matthiasschaub
changed the title
Split georeferencing into multiple tasks
refactor(tasks/routes): process uploaded files in parallel as celery group
Sep 5, 2024
matthiasschaub
changed the title
refactor(tasks/routes): process uploaded files in parallel as celery group
refactor(tasks/routes): process uploaded files in parallel as celery groups
Sep 6, 2024
matthiasschaub
force-pushed
the
split-georeferencing-into-multiple-tasks
branch
3 times, most recently
from
September 9, 2024 09:40
b59b217
to
93ad756
Compare
matthiasschaub
force-pushed
the
split-georeferencing-into-multiple-tasks
branch
5 times, most recently
from
October 14, 2024 21:11
4ce2b37
to
e742f2d
Compare
instead of georeferencing uploaded files in one celery tasks sequential (w/ the output of a single big zip file which if too big leads to memory issues) files are now processed in parallel in one celery group. The same is done for digitize sketches: Digitize files in parallel as celery group instead of as single celery task. Other changes: - refactor: move merge and zip_ to helpers module - refactor(celery): use chord and immutable signature. Use chord for executing task after group is finished.
matthiasschaub
force-pushed
the
split-georeferencing-into-multiple-tasks
branch
from
October 17, 2024 02:56
718f2f3
to
9120d8a
Compare
into test_routes_api_health.py and test_routes_api_status.py
Build user message from changed info and new errors response fields.
Raster and vector results generated by previous version are stored as single AsyncResult in the result store. These need to be retrieved differently as it is now down with GroupResults.
matthiasschaub
force-pushed
the
split-georeferencing-into-multiple-tasks
branch
from
October 19, 2024 03:33
459d343
to
fbb243f
Compare
Some tests cluttered the Celery queue, which led to timeout errors for next test cases.
matthiasschaub
force-pushed
the
split-georeferencing-into-multiple-tasks
branch
from
October 22, 2024 21:15
fbb243f
to
3c3a91c
Compare
of `cleanup_map_frames` and `cleanup_blobs`
matthiasschaub
force-pushed
the
split-georeferencing-into-multiple-tasks
branch
from
October 27, 2024 00:15
3c3a91c
to
6ad8135
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of georeferencing uploaded files in one celery tasks sequential
(w/ the output of a single big zip file, when too big leads to memory
issues) files are now processed in parallel in one salary group.
The same is done for digitize sketches: Digitize files in parallel as
celery group instead of as single celery task.
Closes #498
Closes #399
Other changes:
cleanup_map_frames
andcleanup_blobs
Changed Dependencies
Open Tasks: