Skip to content

Commit

Permalink
Added TODO comments to the skimmer node for #257
Browse files Browse the repository at this point in the history
  • Loading branch information
Isopod00 committed Aug 22, 2024
1 parent cc44346 commit f87846c
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/skimmer/skimmer/skimmer_node.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ def toggle(self, skimmer_belt_power: float) -> None:
else:
self.set_power(skimmer_belt_power)

# TODO: This method can probably be deleted during the implementation of ticket #257
def set_position(self, position: int) -> None:
"""This method sets the position (in degrees) of the skimmer."""
self.current_goal_position = position # goal position should be in degrees
Expand Down Expand Up @@ -157,6 +158,9 @@ def toggle_callback(self, request, response):
response.success = 0 # indicates success
return response

# TODO: This method needs to be modified during the implementation of ticket #257
# to return a proper future indicating when the goal position has been reached
# so that rclpy.spin_until_future_complete() can be used to wait for the goal.
def set_position_callback(self, request, response):
"""This service request sets the position of the lift."""
self.set_position(request.position)
Expand Down

0 comments on commit f87846c

Please sign in to comment.