move initialization of OptionInt/Double parameters to constructor #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
except for id, which isn't known by formats/filters. Also, move validation of OptionInt/Double strings to Option class, where it can be maintained in parallel with the conversion routines.
also fix -Wclazy-unused-non-trivial-variable. add test of Option error detection.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
except for id, which isn't known by the formats/filters which contain the Option instances. Initialization of id is moved to Vecs::init_vec and FilterVecs::init_filter_vec.
Also, move validation of OptionInt/Double strings to Option class, where it can be maintained in parallel with the conversion
routines.