fix synthetic shortname option handling #978
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and make related options parameters bool. the ozi and xcsv writers had ARGTYPE_BOOL options without defaults for must upper, must unique and whitespace ok, but only used them if they were not nullptr. For ARGTYPE_BOOL without defaults false is signified by a value of nullptr. But mkshort defaults whitespace ok and must unique to true, so they were impossible to turn off. add test for the above writers and the related options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and make related options parameters bool.
the ozi and xcsv writers had ARGTYPE_BOOL options without defaults
for must upper, must unique and whitespace ok, but only used them
if they were not nullptr.
For ARGTYPE_BOOL without defaults false is signified by a value of nullptr.
But mkshort defaults whitespace ok and must unique to true, so they were
impossible to turn off.
add test for the above writers and the related options.