Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and enable tests disabled in 854b7b8ab1 #2846

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Update and enable tests disabled in 854b7b8ab1 #2846

merged 1 commit into from
Nov 24, 2023

Conversation

mbrkusanin
Copy link
Contributor

Resolves #2841

@mbrkusanin mbrkusanin requested a review from a team as a code owner November 24, 2023 12:16
Flakebi
Flakebi approved these changes Nov 24, 2023
View reviewed changes
lgc/test/BuiltIns/cs-globalinvocationid.lgc
@@ -1,7 +1,6 @@
; NOTE: Assertions have been autogenerated by tool/update_llpc_test_checks.py UTC_ARGS: --tool lgc
; RUN: lgc -mcpu=gfx1010 - < %s | FileCheck --check-prefixes=GFX8 %s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fooled me by checking for GFX8 while it actually compiled with gfx10.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why GFX8 was used there. Should I update it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently this was not correctly updated in aff7949.
There seem to be more affected tests, I guess we should also fix them if we fix this one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2848

@amdvlk-admin
Copy link
Collaborator

Test summary for commit 4b54d74

CTS tests (Failed: 0/138378)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35162/69163 (50.8%)
    • Failed: 0/69163 (0.0%)
    • Not Supported: 34001/69163 (49.2%)
    • Warnings: 0/69163 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35242/69215 (50.9%)
    • Failed: 0/69215 (0.0%)
    • Not Supported: 33973/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)

@mbrkusanin mbrkusanin merged commit a261205 into GPUOpen-Drivers:dev Nov 24, 2023
10 checks passed
@mbrkusanin mbrkusanin deleted the enable-tests-2841 branch November 24, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasilvanus jasilvanus jasilvanus left review comments

@Flakebi Flakebi Flakebi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tests] Re-enable tests disabled in 854b7b8ab1
4 participants
@mbrkusanin @amdvlk-admin @Flakebi @jasilvanus