Deduplicate constant data tables #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasilvanus
reviewed
Nov 28, 2023
Test summary for commit 829e85fCTS tests (Failed: 0/138443)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
The header file |
AMD-dwang
force-pushed
the
deduplicate_constant_data
branch
from
829e85f
to
87d0d6d
Compare
Test summary for commit 87d0d6dCTS tests (Failed: 0/138443)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
A constant data is assigned to different variables several times, then
we will create multiple globalVariables, which causes the constant data
is repeated in the .rodata section with different names.
Like this:
.rodata (size = 1344 bytes)
__unnamed_3 (offset = 0 size = 448 hash = 0xB186021131D03E38)
(offset = 0 size = 0 hash = 0x071E967D705FB008)
0:3F1FE7C0 3F0B1A4C 3F53F141 00000000 BE095BFF BF71E3A8 3F745048 00000000
32:3EC6833C BEDE978D 3F1520B0 00000000 3DF8572A BE45729B 3E693F29 00000000
...
__unnamed_2 (offset = 448 size = 448 hash = 0xB186021131D03E38)
448:3F1FE7C0 3F0B1A4C 3F53F141 00000000 BE095BFF BF71E3A8 3F745048 00000000
480:3EC6833C BEDE978D 3F1520B0 00000000 3DF8572A BE45729B 3E693F29 00000000
...
__unnamed_1 (offset = 896 size = 448 hash = 0xB186021131D03E38)
896:3F1FE7C0 3F0B1A4C 3F53F141 00000000 BE095BFF BF71E3A8 3F745048 00000000
928:3EC6833C BEDE978D 3F1520B0 00000000 3DF8572A BE45729B 3E693F29 00000000
...
For the globalVariable that the initialization values are the same, we
should treat them as the same variable.
AMD-dwang
force-pushed
the
deduplicate_constant_data
branch
from
87d0d6d
to
f646e54
Compare
Test summary for commit f646e54CTS tests (Failed: 0/138443)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
nhaehnle
approved these changes
Nov 28, 2023
jayfoad
reviewed
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A constant data is assigned to different variables several times, then we will create multiple globalVariables, which causes the constant data is repeated in the .rodata section with different names. Like this:
.rodata (size = 1344 bytes)
__unnamed_3 (offset = 0 size = 448 hash = 0xB186021131D03E38)
(offset = 0 size = 0 hash = 0x071E967D705FB008)
0:3F1FE7C0 3F0B1A4C 3F53F141 00000000 BE095BFF BF71E3A8 3F745048 00000000
32:3EC6833C BEDE978D 3F1520B0 00000000 3DF8572A BE45729B 3E693F29 00000000
...
__unnamed_2 (offset = 448 size = 448 hash = 0xB186021131D03E38)
448:3F1FE7C0 3F0B1A4C 3F53F141 00000000 BE095BFF BF71E3A8 3F745048 00000000
480:3EC6833C BEDE978D 3F1520B0 00000000 3DF8572A BE45729B 3E693F29 00000000
...
__unnamed_1 (offset = 896 size = 448 hash = 0xB186021131D03E38)
896:3F1FE7C0 3F0B1A4C 3F53F141 00000000 BE095BFF BF71E3A8 3F745048 00000000
928:3EC6833C BEDE978D 3F1520B0 00000000 3DF8572A BE45729B 3E693F29 00000000
...
For the globalVariable that the initialization values are the same, we should treat them as the same variable.