Lower private global variables in functions #2850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test summary for commit 4bf8963CTS tests (Failed: 474/138443)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
Usually the functions are inlined into one entry functions before the SpirvLowerGlobal Pass, However in one case, llpc-raytracing-mode=continuations, the module does not inline library functions to entry function. the private global variables are used in multi functions. These private global variables are coming from gpurt hlsl module, usually are enum values hence, these global variables are loaded, but not stored. So we are probably safe lower these variables in there used functions. wer
Test summary for commit b9f91e2CTS tests (Failed: 0/138443)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
Test summary for commit f780231CTS tests (Failed: 0/138378)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually the functions are inlined into one entry functions before the SpirvLowerGlobal Pass, However in one case,
llpc-raytracing-mode=continuations, the module does not inline library functions to entry function. the private global variables are used in multi functions. These private global variables are coming from gpurt hlsl module, which usually are enum values , hence, these global variables are loaded, but not stored. So we are probably safe to lower these variables in there used functions.