Action menu text #1124
Action menu text #1124
Conversation
|
When this becomes a normal PR, for future reference can you include at least the number of the issue this is addressing |
yerramshilpa
requested review from
thomastighe,
carlosvalle,
davereed,
christyhermansen and
cwolf10
as code owners
| @@ -19,6 +19,7 @@ export class SdsActionsMenuComponent { | |||
| if (!menuItem.mode) menuItem.mode = this.actionModes.SHOWN; | |||
| }); | |||
| } | |||
| this.model.isIconMenu = this.model.label ? false : true; | |||
There was a problem hiding this comment.
Is the intention is to allow devs to set this field? If so, I think this value should only be set like this if this value is not set. Otherwise there could be a scenario where the expected value gets changed by this line. If that is not the intent, this should probably be made to an internal variable.
There was a problem hiding this comment.
Removed and refactored the method more generic and added story book documentation
|
Given we are moving to storybook, this change should be reflected in the stories there too. Configurable should be updated to allow Additionally, a story with code-preview enabled would be helpful. There isn't a story currently that would make sense to update with this, so perhaps add another story to highlight these inputs. |
| }, | ||
|
|
||
| table: { | ||
| category: 'ActionMenuModel/actions', |
There was a problem hiding this comment.
Since label isnt part of the actions object, the category should be 'ActionMenuModel'
There was a problem hiding this comment.
Updated the catagory
| @@ -151,4 +178,4 @@ export const Introduction: Story = (args) => ({ | |||
| }); | |||
| Introduction.parameters = { options: { showPanel: false } }; | |||
|
|
|||
| export const __namedExportsOrder = ['Introduction', 'Configurable', 'ModelTrigger', 'Size']; | |||
| export const __namedExportsOrder = ['Introduction', 'Configurable', 'ModelTrigger', 'Size', 'Label']; | |||
There was a problem hiding this comment.
Only introduction and Configurable should be out of alphabetic order. Unfortunately, there ins't a way to tell this to Storybook so we've got to manually make sure the order is right. Stick label before modelTrigger.
There was a problem hiding this comment.
changed to alphabetical order
Description
This PR is for adding text and outline style for the Action Menu, this is specific to Escalation pages.
https://cm-jira.usa.gov/browse/IAEMOD-10402
Motivation and Context
Type of Change (Select One and Apply Github Label)
Screenshots (if appropriate):
Which browsers have you tested?
Checklist: