Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sb stepper #1480

Merged
merged 7 commits into from
Jul 25, 2024
Merged

Sb stepper #1480

merged 7 commits into from
Jul 25, 2024

Conversation

shayan-roshan
Copy link
Collaborator

Description

added the stepper demo to storybook

Motivation and Context

Type of Change (Select One and Apply Github Label)

  • Bug fix (non-breaking change which fixes an issue) -> Apply bugfix label
  • New feature (non-breaking change which adds functionality) -> Apply enhancement label
  • Breaking change (fix or feature that would cause existing functionality to change) -> Apply breaking label

Screenshots (if appropriate):

Which browsers have you tested?

  • Internet Explorer 11
  • Edge
  • Chrome
  • Firefox
  • Safari

Checklist:

Copy link

github-actions bot commented Jun 10, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-25 14:20 UTC

),
]
),
stackblitzLink: generateStackblitzLink('formly-stepper', 'uswds'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check this configuration, it is not going to the correct path.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the link seems to open, what is wrong over here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so when I click on the stackblitz link in the uneven demo, then it shows the path that you mentioned, it is just named differently but it points to the right folder.

Copy link
Collaborator

@cwolf10 cwolf10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shayan-roshan shayan-roshan merged commit 14de822 into master Jul 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants