Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Condition To Prevent Horizontal Filter Without Label #1530

Merged
merged 6 commits into from
Sep 9, 2024

Conversation

cwolf10
Copy link
Collaborator

@cwolf10 cwolf10 commented Sep 9, 2024

Description

Update condition to not render field if label is not present.
Add documentation to explain changes to horizontal filter configs caused by 17.0.7-.9

Motivation and Context

With the latest popover changes FormlyFieldConfig parsing has changed requiring that each top-level FormlyFieldConfig contain a label to display on the toolbar. This change continues to enforces that without causing breaking console errors.

Type of Change (Select One and Apply Github Label)

  • Bug fix (non-breaking change which fixes an issue) -> Apply bugfix label
  • New feature (non-breaking change which adds functionality) -> Apply enhancement label
  • Breaking change (fix or feature that would cause existing functionality to change) -> Apply breaking label

Screenshots (if appropriate):

image

Which browsers have you tested?

  • Internet Explorer 11
  • Edge
  • Chrome
  • Firefox
  • Safari

Checklist:

Copy link

github-actions bot commented Sep 9, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-09-09 20:28 UTC

@yerramshilpa yerramshilpa merged commit 704b5bf into master Sep 9, 2024
3 checks passed
@yerramshilpa yerramshilpa deleted the hor-filter-label branch September 9, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants